Nuclear Reset Fix: Marker-Based Two-Phase Reset

🐛 The Problem

The nuclear reset button was clearing all storage successfully but data was mysteriously reappearing after page reload!

Root Cause Analysis (Multiple Issues Found)

The logs revealed a critical race condition:

✅ All IndexedDB databases deleted
✅ Nuclear reset complete! Forcing hard reload...
⚡ [BEFOREUNLOAD] Attempting to flush pending persistence...  ⚠️ <- CULPRIT!

What was happening:

1. Nuclear reset deletes all IndexedDB databases ✅
2. Nuclear reset triggers redirect to /landing
3. Browser fires beforeunload event before navigation
4. App's beforeunload handler flushes in-memory state back to storage 💥
5. Deleted universes get re-saved from memory!
6. Page reloads with "deleted" data magically restored

Why Delete Button Worked

The individual delete button worked perfectly because:

• It doesn't trigger page reload
• No beforeunload event fires
• Memory and storage updates happen together
• No race condition

✅ The Solution

1. Added Disable Flag to AppComponent

// ☢️ Flag to disable persistence flush during nuclear reset
private static disableFlushOnUnload = false;

/**
 * ☢️ PUBLIC API: Disable flush on unload (for nuclear reset)
 */
public static disablePersistenceFlush(): void {
  AppComponent.disableFlushOnUnload = true;
  console.log('☢️ [AppComponent] Persistence flush DISABLED for nuclear reset');
}

2. Modified beforeunload Handler

private handleBeforeUnload = () => {
  // ☢️ CRITICAL: Skip flush if nuclear reset is in progress
  if (AppComponent.disableFlushOnUnload) {
    console.log('☢️ [BEFOREUNLOAD] Flush DISABLED for nuclear reset - data will not be re-saved');
    return;
  }
  
  console.log('⚡ [BEFOREUNLOAD] Attempting to flush pending persistence...');
  this.flashHydrator.flushPendingPersistence().catch(error => {
    console.error('⚡ [BEFOREUNLOAD] Flush failed:', error);
  });
};

3. Modified Visibility Change Handler

Also protected the visibility change handler (fires when user switches tabs):

private handleVisibilityChange = async () => {
  if (document.hidden) {
    // ☢️ CRITICAL: Skip flush if nuclear reset is in progress
    if (AppComponent.disableFlushOnUnload) {
      console.log('☢️ [VISIBILITY] Flush DISABLED for nuclear reset - data will not be re-saved');
      return;
    }
    
    // ... flush logic
  }
};

4. Updated Nuclear Reset Flow

Added Step 0 to disable flush before clearing data:

async nuclearReset(): Promise<void> {
  try {
    // 0. ☢️ CRITICAL: Disable beforeunload flush to prevent data from being re-saved
    console.log('🧹 Step 0: Disabling persistence flush on page unload...');
    (await import('../../../app.component')).AppComponent.disablePersistenceFlush();
    console.log('✅ Persistence flush disabled');

    // 1-10. Continue with clearing process...
    // ...
  }
}

🎯 Expected Results

With this fix, the nuclear reset should now:

1. ✅ Disable persistence flush before clearing data
2. ✅ Clear user context, guest sessions, Flash Persistence
3. ✅ Clear space/universe data and sync queue
4. ✅ Nuclear cache reset (micro-cache + boot manifests)
5. ✅ Clear localStorage and sessionStorage
6. ✅ Delete ALL IndexedDB databases with proper await
7. ✅ Redirect to /landing
8. ✅ beforeunload event fires but SKIPS flush 🎉
9. ✅ Page reloads with completely clean state

📊 Console Logs to Verify

On the next nuclear reset attempt, you should see:

☢️ NUCLEAR RESET INITIATED
🧹 Step 0: Disabling persistence flush on page unload...
☢️ [AppComponent] Persistence flush DISABLED for nuclear reset
✅ Persistence flush disabled
🧹 Step 1: Clearing user context...
...
✅ All IndexedDB databases deleted
☢️ [BEFOREUNLOAD] Flush DISABLED for nuclear reset - data will not be re-saved  ✅ <- SUCCESS!

🏗️ Architecture Impact

This fix demonstrates an important consideration for offline-first architectures:

• Automatic persistence is powerful but must respect destructive operations
• Race conditions can occur between storage clearing and automatic flushes
• Explicit control flags are needed for special cases like nuclear resets
• All persistence points (beforeunload, visibilitychange) need protection

📝 Related Files

• apps/gograb-space/src/app/app.component.ts - Added disable flag and protected flush handlers
• apps/gograb-space/src/app/components/space-components/g-space-dashboard/g-space-dashboard.component.ts - Updated nuclear reset to disable flush

🧪 Testing Verification

To test:

1. Create test universes
2. Click nuclear reset button (☢️)
3. Confirm both warnings
4. Watch console logs
5. After redirect, verify NO universes exist
6. Check IndexedDB in DevTools → Should be empty or new DB

Status: ✅ Implemented
Impact: Critical - Ensures nuclear reset actually works
Performance: None - Only affects nuclear reset flow