Deprecated Generation Code Cleanup — Post-S204

Background

S204 discovered that the platform generation pipeline had TWO parallel systems:

1. backend-ai-api WorkflowService with full-configuration workflow type — a template-selection system that matched business descriptions to predefined templates. It NEVER decomposed requirements into actual modules (always produced 0 modules).
2. backend-vitto-api ModuleGenerationService with a real 6-phase pipeline (PRE-FLIGHT, ENHANCE, ANALYZE, DECOMPOSE, PLAN, EXECUTE, DEPLOY) — the correct, working system.

S204 fixed routing so all entry points now delegate to the Vitto pipeline:

• GenerationHubService.startGeneration() (frontend lib, S204.5) now calls startVittoGeneration() directly
• The broken full-configuration workflow path is bypassed entirely

This session should remove the dead code left behind by that rerouting.

Files to Read First

Read these files in order before making any changes:

1. apps/backend-ai-api/src/app/workflow/workflow.types.ts — WorkflowType union, WORKFLOW_TEMPLATES constant
2. apps/backend-ai-api/src/app/workflow/workflow.service.ts — execute() method, full-configuration handler
3. apps/backend-ai-api/src/app/workflow/workflow.controller.ts — POST/GET /workflow/start endpoints + module/generate endpoints
4. libs/libs-ai/ai-generation-hub/src/lib/services/generation-hub.service.ts — main frontend orchestration service (~1200 lines)
5. libs/libs-structural/vibe-universe/src/lib/components/vibe-universe-generator/vibe-universe-generator.component.ts — calls startGeneration()
6. libs/libs-ai/ai-outcome-tracker/src/lib/types/module-outcome.types.ts — GenerationSource type

Cleanup Tasks

Task 1: Remove Dead Workflow Types from backend-ai-api

File: apps/backend-ai-api/src/app/workflow/workflow.types.ts

The WorkflowType union (line 12-18) defines 6 types. After S204, only single-module generation via PhaseExecutorService is active. The following types are dead:

Action:

• Remove these 6 values from the WorkflowType union
• Remove their entries from WORKFLOW_TEMPLATES constant (lines 298-443)
• Keep the SSE event types (WorkflowSSEEvent and its sub-interfaces) — they may still be referenced by PhaseExecutorService or other importers
• Search for all imports of WorkflowType and WORKFLOW_TEMPLATES before removal to check impact

Verification: npx tsc --noEmit on backend-ai-api after changes.

Task 2: Audit WorkflowService.execute() and Controller Endpoints

File: apps/backend-ai-api/src/app/workflow/workflow.service.ts

The execute() method handles the broken full-configuration flow. Check:

• Whether execute() is called from anywhere besides the controller's startWorkflow / startWorkflowSSE endpoints
• Whether any other service or external caller still hits POST /ai-api/workflow/start or GET /ai-api/workflow/start

File: apps/backend-ai-api/src/app/workflow/workflow.controller.ts

Endpoints to evaluate:

Action:

• Remove the dead endpoints and their handler methods
• Remove the WorkflowService dependency from the controller constructor if execute() / continue() / getStatus() are no longer called
• Do NOT remove the PhaseExecutorService import or any module/generate endpoints
• Check WorkflowModule (apps/backend-ai-api/src/app/workflow/workflow.module.ts) for providers that can be removed

Verification: Search for workflow/start in all frontend code to confirm no callers remain.

Task 3: Remove Dead Methods from GenerationHubService

File: libs/libs-ai/ai-generation-hub/src/lib/services/generation-hub.service.ts

After S204.5 rerouted startGeneration() to call startVittoGeneration() directly, the following private methods are dead (no callers):

Dead methods (confirmed by grep, all private):

Action:

• Remove all 14 dead methods listed above
• Remove the eventSource field (line 51) ONLY IF it is not used by the Vitto SSE stream methods (startVittoSSEStream). Check carefully — the Vitto path may use fetch() instead of EventSource.
• Remove any imports that become unused after deletion
• Keep: startGeneration(), startVittoGeneration(), startVittoSSEStream(), enhancePromptVitto(), initializeVittoProgress(), all public signals, setMode(), getRequestDescription(), completeProgress(), failProgress(), and any methods used by the Vitto SSE flow

Estimated removal: ~700 lines of dead code.

Verification: npx tsc --noEmit on ai-generation-hub and any app that imports it.

Task 4: Audit vibe-universe-generator Component

File: libs/libs-structural/vibe-universe/src/lib/components/vibe-universe-generator/vibe-universe-generator.component.ts

This component calls startGeneration() (confirmed at lines 1289, 1305, 2911, 2988). Since startGeneration() now delegates to startVittoGeneration(), the component should work correctly without changes.

Action:

• Verify the component does NOT directly construct SSE URLs to /ai-api/workflow/start
• Verify it only uses GenerationHubService.startGeneration() (which is now correct)
• No changes expected — just confirm

Task 5: Audit ToolOrchestrationService References

File: libs/libs-foundational/core-angular/src/lib/services/tool-orchestration.service.ts

This service coordinates navigation between platform building tools (vibe-universe, modular-universe, module-workbench, etc.). It references ai-generation-hub as a tool conceptually but does NOT import or call GenerationHubService directly.

Action:

• Verify no direct dependency on the broken workflow path
• No changes expected — just confirm

Task 6: Update GenerationSource Type

File: libs/libs-ai/ai-outcome-tracker/src/lib/types/module-outcome.types.ts

Current type (line 13):

export type GenerationSource = 'ai-panel' | 'module-workbench' | 'cursor-agent' | 'visual-builder';

This type tracks where a module was generated from. It does NOT include 'ai-generation-hub' as previously suggested. However, with the Vitto pipeline now being the canonical path:

Action:

• Add 'vitto-pipeline' to the union: 'ai-panel' | 'module-workbench' | 'cursor-agent' | 'visual-builder' | 'vitto-pipeline'
• Check module-outcome-tracker.service.ts line 612 where sources are hardcoded in getStatsBySource() and add the new value
• This is additive — no breaking changes

Task 7: Remove Unused WorkflowService Dependencies

File: apps/backend-ai-api/src/app/workflow/workflow.service.ts

After removing the broken flow, check if these injected services are still needed:

• TemplateToolsService — used only in template-matching phase
• ManifestAdapterService — used only in manifest-export phase
• ModuleCatalogService — check if PhaseExecutorService also uses it
• ModuleCodeGeneratorService — check if PhaseExecutorService also uses it
• BackendAPIGeneratorService — check if PhaseExecutorService also uses it
• PlatformOrchestrationService — check usage

For each, search for imports across the entire workflow directory. If only WorkflowService uses them, they can be removed from the module providers too.

Verification Checklist

After all changes:

1. TypeScript compilation:

   npx tsc --noEmit -p apps/backend-ai-api/tsconfig.app.json
   npx tsc --noEmit -p libs/libs-ai/ai-generation-hub/tsconfig.lib.json
   npx tsc --noEmit -p libs/libs-ai/ai-outcome-tracker/tsconfig.lib.json
   

2. Search for dangling references:

   # Search for removed method names
   grep -r "startStreamingWorkflow\|mapModeToWorkflowType\|full-configuration" --include="*.ts" libs/ apps/
   
   # Search for removed workflow start endpoint
   grep -r "workflow/start" --include="*.ts" libs/ apps/
   

3. Confirm Vitto path still works:

   • GenerationHubService.startGeneration() should still compile and route to startVittoGeneration()
   • GenerationHubService.startVittoGeneration() should still call VITTO_API_BASE/generate
   • vibe-universe-generator component should still call startGeneration() without errors

4. Backend module wiring:

   • Check WorkflowModule providers array — remove services that are no longer injected anywhere
   • Verify the module still exports PhaseExecutorService and its dependencies

Anti-Patterns to Avoid

Estimated Impact

Commit Convention

Follow SAGP v1.2:

[S{N}.1] refactor: remove dead workflow types from backend-ai-api
[S{N}.2] refactor: remove dead methods from GenerationHubService
[S{N}.3] refactor: remove dead controller endpoints from WorkflowController
[S{N}.4] feat: add 'vitto-pipeline' to GenerationSource type
[S{N}.5] refactor: remove unused WorkflowService dependencies

Where {N} is the session number assigned to this cleanup work.