Architecture: Session 54.8: Should we deprecate 'duplicate' state services...

Documentation for Sessions

🏗️ Architecture: Session 54.8: Should we deprecate 'duplicate' state services...

Date: 2026-01-22
Time: 04:12:47 UTC
Session: editor2-54.9
Agent: angular
Confidence: 95%
Status: ✅ Documented

📋 Decision Context

Question:

Session 54.8: Should we deprecate 'duplicate' state services and types?

Task: Not specified

🎯 Decision Made

Chosen:

No - they're layered architecture by design

Options Considered:

Yes - they're duplicates causing confusion
No - they're layered architecture by design
Partial - keep some, deprecate others

💭 Reasoning

Investigation revealed: (1) AIPanelStateService in vitto-hub is a FACADE over AIPanelCoreStateService - it injects the core service (line 61) and delegates all methods. Core avoids circular deps, facade adds flash-persistence (line 103: autoFlashState). (2) module-generation.types.ts provides LIGHTWEIGHT types for consumers who don't need rich models. module-schema.model.ts extends @libs-core contracts with full validation, UI config, templates. They serve different consumers at different complexity levels. NOT duplicates - deliberate layered architecture. Documentation should be improved, not code deprecated.

📁 Files Involved

libs/libs-ai/ai-panel-core/src/lib/services/ai-panel-state.service.ts
libs/libs-ai/vitto-hub/src/lib/services/ai-panel-state.service.ts
libs/libs-ai/module-generator/src/lib/types/module-generation.types.ts
libs/libs-ai/module-generator/src/lib/models/module-schema.model.ts

🔗 Related

Decision ID: dev_1769055167741_yi090if
Session: 54
Workspace: editor2

Auto-generated by MCP Smart Consolidation